Sanitize URL well #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a security update and I highly urge you to update your code immediately to stay secure. This fixes the following security issues - XSS These issue may have a "High" impact as they may compromise the confidentiality, availability, and integrity of servers to the victim. This update also includes a new method, `mrk.sanitizeURL(url)`, which should be used for all `src` and `href` attributes. You must use this **together with** the existing HTML sanitizer. This pull request has not been tested.
|
I have verified this locally, it looks good to me |
|
(ping @heyitsmeuralex) @joker314 I don't have push permission to this repository :P |
|
Will fixing this here automatically fix it in Decent; or did you make a seperate copy of mrk in the decent repo? @towerofnix |
|
I'll publish a new version as soon as I get home. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a security update and I highly urge you to update your code immediately to stay secure.
This fixes the following security issues
These issues may have a "High" impact if the markdown parser is used in a chatroom system that accepts user input; and user accounts are enforced.
This update also includes a new method,
mrk.sanitizeURL(url), which should be used for allsrcandhrefattributes. You must use this together with the existing HTML sanitizer.This pull request has not been tested.