Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates filter icon; adds signalserver icons #247

Merged
merged 2 commits into from
Dec 27, 2016
Merged

Conversation

ablwr
Copy link
Contributor

@ablwr ablwr commented Dec 24, 2016

Updates filters_layout.

Adds "Upload to signalserver" icon.

Adds three icons to serve as progress bar for signalserver: not uploaded, uploading, error, and successfully uploaded.

Copy link
Member

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and so fancy

@retokromer
Copy link
Contributor

LGTM

@ablwr
Copy link
Contributor Author

ablwr commented Dec 27, 2016

@dericed @ElderOrb who is in charge of merging this in? I'll let one of you do it.

@dericed dericed merged commit 597bedc into bavc:master Dec 27, 2016
@ElderOrb
Copy link
Collaborator

ElderOrb commented Jan 3, 2017

Sorry for the delay, looks good anyway!

Copy link
Collaborator

@ElderOrb ElderOrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ablwr ablwr mentioned this pull request Jan 5, 2017
@ablwr ablwr deleted the ab/new-icons branch August 15, 2017 15:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants