-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add browser module main priority to amd processor #761
Conversation
I was thinking this would be the next improvement to the AMD processor. We may want to add the es6ify plugin with this change as well since some npm packages may use es6 or fesm5 in their distributions. generate_build_file.js needs some refactoring at some point as well; it started out small and simple and has become rather large overtime. |
@gregmagolan Sounds good to me |
I took a glance at es6ify and it's a more complicated plugin than the named-amd plugin that I previously vendored in. I'll put this on my list but probably won't have time to get to it for a few weeks. |
@Toxicable any plan how to get this green without es6ify plugin ? or should this go on the backlog? |
@alexeagle Definately needs the es6ify plugin for this one, since the test case I choose; |
Replaced by #997 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The entry point for npm_umd_bundle in npm packages is only resolved to
main
What is the new behavior?
We now try to resolve,
browser
,module
, thenmain
, thenindex.js
and finally${pkg.__name}.js
Does this PR introduce a breaking change?
Not sure, possibly
Other information