Negation support #412
Open
Negation support #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW the failure with bzlmod looks similar to the failure discussed on #411 where fmeum wrote: |
|
@leovitch These failures should be fixed by bazelbuild/bazel#16755. Once it has been merged, you can do a trivial amend of your commits and force push to trigger a rerun of the pipeline. |
leovitch
requested review from
brandjon,
tetromino,
comius,
hvadehra and
c-mita
as code owners
|
Thanks for the note Fabian! |
…g_group. Currently config_setting_group can be used to evaluate AND or OR expression or other config_setting or config_setting_group nodes. However, it cannot currently evaluate expressions such as A AND NOT B. This CL adds that capability.
bzlmod compatibility Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
bzlmod compatibility Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
leovitch
force-pushed
the
negation_support
branch
from
33d8d2b to
8e4a8de
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to negate individual elements of a config_settings_group(), so that you can construct groups that evaluate conditions like "match config_setting 1 and do not match config_setting 2." This is very helpful when making sure that the list of conditions in a select match once and only once.