Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement the execution transition #7935

Closed
katre opened this issue Apr 3, 2019 · 1 comment
Closed

Implement the execution transition #7935

katre opened this issue Apr 3, 2019 · 1 comment
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@katre
Copy link
Member

katre commented Apr 3, 2019

Implementation tracking issue for https://github.com/bazelbuild/proposals/blob/master/designs/2019-02-12-execution-transitions.md.

This is separate from migrating uses of the host transition, which will be a separate followup issue.
@katre katre added type: feature request P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions labels Apr 3, 2019
@katre katre self-assigned this Apr 3, 2019
katre added a commit to katre/bazel that referenced this issue Apr 3, 2019
@katre
Rename ToolchainContext to ResolvedToolchainContext.
9b21ef9 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 3, 2019
@katre
Move UnloadedToolchainContext to a top-level class.
fd6adb1 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 3, 2019
@katre
Add ToolchainContext to ConfiguredTarget.
9e4c385 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 3, 2019
@katre
Pass the ToolchainContext into DependencyResolver instead of just the
ce52573 
list of toolchain dependencies.

Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 3, 2019
@katre
Add the ToolchainContext to AttributeTransitionData.
9ff0661 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 5, 2019
@katre
Rename ToolchainContext to ResolvedToolchainContext.
9f141a1 
Part of work on execution transitions, bazelbuild#7935.
@katre katre mentioned this issue Apr 5, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 5, 2019
@katre @copybara-github
Rename ToolchainContext to ResolvedToolchainContext.
cdfa9ca 
Part of work on execution transitions, #7935.

Closes #7960.

PiperOrigin-RevId: 242172690
katre added a commit to katre/bazel that referenced this issue Apr 5, 2019
@katre
Move UnloadedToolchainContext to a top-level class.
e220644 
Part of work on execution transitions, bazelbuild#7935.
@katre katre mentioned this issue Apr 5, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 5, 2019
@katre @copybara-github
Move UnloadedToolchainContext to a top-level class.
99ed053 
Part of work on execution transitions, #7935.

Closes #7963.

PiperOrigin-RevId: 242199824
katre added a commit to katre/bazel that referenced this issue Apr 8, 2019
@katre
Add ToolchainContext to ConfiguredTarget.
fabe0cb 
Part of work on execution transitions, bazelbuild#7935.
@katre katre mentioned this issue Apr 8, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Apr 15, 2019
@katre
Move UnloadedToolchainContext.load to ResolvedToolchainContext.
924f447 
Also pass target description directly to load().

Part of work on execution transitions, bazelbuild#7935.
@katre katre mentioned this issue Apr 15, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 16, 2019
@katre @copybara-github
Move UnloadedToolchainContext.load to ResolvedToolchainContext.
5074514 
Also pass target description directly to load().

Part of work on execution transitions, #7935.

Closes #8045.

PiperOrigin-RevId: 243805205
katre added a commit to katre/bazel that referenced this issue Apr 16, 2019
@katre
Rename ToolchainResolutionFunction to SingleToolchainResolutionFunction.
778635e 
Part of work on execution transitions, bazelbuild#7935.
@katre katre mentioned this issue Apr 16, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Apr 16, 2019
@katre
Convert ToolchainResolver to ToolchainResolutionFunction.
791190e 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 16, 2019
@katre
Fix users of toolchain resolution to call the new skyfunction.
235ce9d 
Part of work on execution transitions, bazelbuild#7935.
bazel-io pushed a commit that referenced this issue Apr 16, 2019
@katre @copybara-github
Rename ToolchainResolutionFunction to SingleToolchainResolutionFunction.
a3df53c 
Part of work on execution transitions, #7935.

Closes #8065.

PiperOrigin-RevId: 243843398
katre added a commit to katre/bazel that referenced this issue Apr 16, 2019
@katre
Convert ToolchainResolver to ToolchainResolutionFunction.
f2bad72 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 16, 2019
@katre
Fix users of toolchain resolution to call the new skyfunction.
ba27bf3 
Part of work on execution transitions, bazelbuild#7935.
@katre katre mentioned this issue Apr 16, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Apr 18, 2019
@katre
Convert ToolchainResolver to ToolchainResolutionFunction.
0f47f81 
Part of work on execution transitions, bazelbuild#7935.
katre added a commit to katre/bazel that referenced this issue Apr 18, 2019
@katre
Convert ToolchainResolver to ToolchainResolutionFunction.
f4acdec 
Part of work on execution transitions, bazelbuild#7935.
bazel-io pushed a commit that referenced this issue May 7, 2019
@katre @copybara-github
The execution transition should not hard-code the output dir.
bd24ff7 
Part of work on execution transitions, #7935.

PiperOrigin-RevId: 247073726
@Globegitter Globegitter mentioned this issue May 10, 2019
Closed
bazel-io pushed a commit that referenced this issue May 15, 2019
@katre @copybara-github
Update getHost methods to also copy host flags, for use in exec->host…
d1bec22 
… transitions.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248345771
bazel-io pushed a commit that referenced this issue May 15, 2019
@katre @copybara-github
Update getHost methods to also copy host flags, for use in exec->host…
9eaa3cd 
… transitions.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248350730
bazel-io pushed a commit that referenced this issue May 15, 2019
@katre @copybara-github
Update getHost methods to also copy host flags, for use in exec->host…
74c927f 
… transitions.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248371992
bazel-io pushed a commit that referenced this issue May 15, 2019
@katre @copybara-github
Update getHost methods to also copy host flags, for use in exec->host…
6ec7e47 
… transitions.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248372791
bazel-io pushed a commit that referenced this issue May 15, 2019
@katre @copybara-github
Update getHost methods to also copy host flags, for use in exec->host…
1df4438 
… transitions.

Currently, the exec transition also calls getHost. As currently implemented, this means any host_* options get reset to defaults, instead of what was actually passed. In a further transition to a real host config, the expected set of flags won't be set.

This change fixes getHost so that host_* options are kept, so that exec->host transitions work as expected.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248386317
bazel-io pushed a commit that referenced this issue May 17, 2019
@katre @copybara-github
Fix Android transitions to not change the host crosstool top, and to …
c51a250 
…maintain the value of the configuration distinguisher.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248685595
bazel-io pushed a commit that referenced this issue May 17, 2019
@katre @copybara-github
Fix the execution transition to add a unique platform-based suffix to…
31ac63a 
… the output path.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 248727403
bazel-io pushed a commit that referenced this issue May 29, 2019
@katre @copybara-github
Retain the apple configuration distinguisher during host and exec tra…
9e84993 
…nsitions.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 250485307
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Update getHost methods to also copy host flags, for use in exec->host…
f23b17b 
… transitions.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248345771
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Update getHost methods to also copy host flags, for use in exec->host…
cbd21a4 
… transitions.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248350730
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Update getHost methods to also copy host flags, for use in exec->host…
4891216 
… transitions.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248371992
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Update getHost methods to also copy host flags, for use in exec->host…
4f61c57 
… transitions.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248372791
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Update getHost methods to also copy host flags, for use in exec->host…
b7c44e1 
… transitions.

Currently, the exec transition also calls getHost. As currently implemented, this means any host_* options get reset to defaults, instead of what was actually passed. In a further transition to a real host config, the expected set of flags won't be set.

This change fixes getHost so that host_* options are kept, so that exec->host transitions work as expected.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248386317
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Fix Android transitions to not change the host crosstool top, and to …
0b89fea 
…maintain the value of the configuration distinguisher.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248685595
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Fix the execution transition to add a unique platform-based suffix to…
1e9a634 
… the output path.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 248727403
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Retain the apple configuration distinguisher during host and exec tra…
b5b5783 
…nsitions.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 250485307
bazel-io pushed a commit that referenced this issue Jul 8, 2019
@katre @copybara-github
Add startup flag, --incompatible_enable_execution_transition, which w…
6bd0aa4 
…ill enable incremental migration of host attributes to exec attributes.

This has to be a startup flag because it will influence rule creation. Changing this flag will completely restart the Blaze server.

Part of work on execution transitions, #7935.

RELNOTES: Adds --incompatible_enable_execution_transition, which enables incremental migration of host attributes to exec attributes.
PiperOrigin-RevId: 256990772
bazel-io pushed a commit that referenced this issue Jul 8, 2019
@katre @copybara-github
Thread new incompatible flag into creation of execution transitions d…
0321a15 
…uring rule creation.

Part of work on execution transitions, #7935.

PiperOrigin-RevId: 257036118
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@katre @irengrig
Retain the apple configuration distinguisher during host and exec tra…
1b6169f 
…nsitions.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 250485307
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@katre @irengrig
Add startup flag, --incompatible_enable_execution_transition, which w…
59db663 
…ill enable incremental migration of host attributes to exec attributes.

This has to be a startup flag because it will influence rule creation. Changing this flag will completely restart the Blaze server.

Part of work on execution transitions, bazelbuild#7935.

RELNOTES: Adds --incompatible_enable_execution_transition, which enables incremental migration of host attributes to exec attributes.
PiperOrigin-RevId: 256990772
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@katre @irengrig
Thread new incompatible flag into creation of execution transitions d…
c428db5 
…uring rule creation.

Part of work on execution transitions, bazelbuild#7935.

PiperOrigin-RevId: 257036118
@johnynek johnynek mentioned this issue Jul 29, 2019
Open
bazel-io pushed a commit that referenced this issue Aug 6, 2019
@katre @copybara-github
Add option flag to note which configurations are execution configurat…
3a87928 
…ions.

Part of #7935.

PiperOrigin-RevId: 261980112
bazel-io pushed a commit that referenced this issue Aug 7, 2019
@katre @copybara-github
Rename cc toolchain's "isHost" concept to include tools as well.
320e45a 
Part of #7935.

PiperOrigin-RevId: 262132230
bazel-io pushed a commit that referenced this issue Aug 8, 2019
@katre @copybara-github
Correct flags set in getHost to correctly capture a host/exec environ…
78829b4 
…ment.

Part of #7935.

PiperOrigin-RevId: 262360499
@katre katre mentioned this issue May 11, 2020
Closed
@katre
Copy link
Member Author

katre commented May 11, 2020

This is fully implemented, remaining configuration issues should be reported separately so they can be triaged and fixed.

@katre katre closed this as completed May 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre