Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"WORKSPACE file can not be a symlink" exception thrown: backward-incompatible bug #8475

Closed
irengrig opened this issue May 28, 2019 · 2 comments
Closed

"WORKSPACE file can not be a symlink" exception thrown: backward-incompatible bug #8475

irengrig opened this issue May 28, 2019 · 2 comments
Assignees
@irengrig
Labels
breakage P1 I'll work on this now. (Assignee required)

Comments

@irengrig
Copy link
Contributor

Bazel 0.26,
if the WORKSPACE file is a symlink, an exception is thrown.
This is not intended change, it should be thrown only if managed directories are used in the project.
@irengrig irengrig self-assigned this May 28, 2019
@irengrig irengrig added breakage P1 I'll work on this now. (Assignee required) labels May 28, 2019
@hlopko hlopko mentioned this issue May 28, 2019
Closed
@hlopko
Copy link
Member

hlopko commented May 28, 2019

Thanks for working on the fix! :)

@irengrig irengrig mentioned this issue May 28, 2019
Closed
@hlopko
Copy link
Member

hlopko commented May 30, 2019

FYI, this issue also breaks tulsi (https://buildkite.com/bazel/tulsi-bazel-darwin/builds/161). CC @DavidGoldman. Patch release with the fix is being prepared.

aehlig pushed a commit that referenced this issue Jun 3, 2019
@irengrig @aehlig
Allow WORKSPACE file to be a symlink if no managed directories is used.
6ca90ac 
Fixes #8475.
Introduced in 0.26 with managed directories support changes.

Closes #8480.

PiperOrigin-RevId: 250490084
aehlig pushed a commit that referenced this issue Jun 4, 2019
@irengrig @aehlig
Allow WORKSPACE file to be a symlink if no managed directories is used.
960c604 
Fixes #8475.
Introduced in 0.26 with managed directories support changes.

Closes #8480.

PiperOrigin-RevId: 250490084
bazel-io pushed a commit that referenced this issue Jun 6, 2019
@aehlig
Release 0.26.1 (2019-06-06)
e6976fb 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- #8475
- #8520
- bazelbuild/intellij#845
AlessandroPatti pushed a commit to uber-common/bazel that referenced this issue Jun 6, 2019
@aehlig
Release 0.26.1 (2019-06-06)
cfc6800 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- bazelbuild#8475
- bazelbuild#8520
- bazelbuild/intellij#845
@jin jin mentioned this issue Jun 17, 2019
Closed
irengrig added a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@irengrig
Allow WORKSPACE file to be a symlink if no managed directories is used.
86d609b 
Fixes bazelbuild#8475.
Introduced in 0.26 with managed directories support changes.

Closes bazelbuild#8480.

PiperOrigin-RevId: 250490084
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@irengrig
Release 0.26.1 (2019-06-06)
6f5cae4 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- bazelbuild#8475
- bazelbuild#8520
- bazelbuild/intellij#845
irengrig added a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@irengrig
Allow WORKSPACE file to be a symlink if no managed directories is used.
9411310 
Fixes bazelbuild#8475.
Introduced in 0.26 with managed directories support changes.

Closes bazelbuild#8480.

PiperOrigin-RevId: 250490084
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@irengrig
Release 0.26.1 (2019-06-06)
5d5105d 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- bazelbuild#8475
- bazelbuild#8520
- bazelbuild/intellij#845
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@irengrig irengrig

Labels
breakage P1 I'll work on this now. (Assignee required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow WORKSPACE file to be a symlink if no managed directories is used.
2 participants
@hlopko @irengrig