Fix output=locations display source file location #12329
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch to fix this commit after being brought up here.
The goal of this PR is to align the output of
--output=location
with its current definition in the documentation. With the flag--output=location
, source files are supposed to output "the location of line 1 of the actual file" but only displayed its location in the BUILD file prior to the commit.Expected behavior by definition:
The previous commit wrongly modified the output to the following (with the
--incompatible_display_source_file_location
flag):This PR fixes it to output to the correct implementation (with the
--incompatible_display_source_file_location
flag):