Fix error message from getPrerequisites to not print internal details. #12551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliexxia
approved these changes
Nov 24, 2020
| @@ -131,8 +131,8 @@ public boolean isTestSuite(ConfiguredTarget target) { | |||
| throw new QueryException( | |||
| caller, | |||
| String.format( | |||
| "%s %s of type %s does not have attribute '%s'", | |||
| errorMsgPrefix, actualConfiguredTarget, rule.getRuleClass(), attrName), | |||
| "%sconfigured target of type %s does not have attribute '%s'", | |||
There was a problem hiding this comment.
does this need a space between %s and configured ? It looks fine in the test but the error message above does seem to have a space after errorMsgPrefix.
There was a problem hiding this comment.
No, the passed-in prefix already has the space, and I didn't want to try and fix all the other uses to make it look nicer here.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of work on #11993.