use absolute directories paths while deriving targets

[kusaeva]

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6439

Description of this change

Use absolute paths for directories excluded from project view

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[mai93]

thanks for the change, can you add a test for this, maybe in https://github.com/bazelbuild/intellij/blob/master/java/tests/unittests/com/google/idea/blaze/java/sync/importer/BlazeJavaWorkspaceImporterTest.java?

[kusaeva]

Hey, @mai93, thanks for the quick review!

I had to add a new test class with the BlazeQueryDirectoryToTargetProvider.getQueryString check, because that's the only way I managed to fail the test with the old code and pass with the new one.
I have used a temporary virtual file system provider so that I could create some fake file structure to verify the existence of directories included or excluded from the project.

I also had to change test_package_root in intellij_integration_test_suite because I'm testing a protected method from the package com.google.idea.blaze.base.dependencies.

Let me know if it is not ok for you

[kusaeva]

Hey, @mai93 @tpasternak @agluszak @jastice!
I guess this plugin is not your priority, but still will be glad to get some feedback :)

[mai93]

Can you make it public and annotate it with @VisibleForTesting instead of changing the package in the test target?

[kusaeva]

done