fix issues with aspect templates not available in query sync mode #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuansontrinh
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
xuansontrinh
force-pushed
the
son/fix-aspect-template-qs
branch
from
9017854 to
fc9a470
Compare
tpasternak
suggested changes
Nov 25, 2024
base/src/com/google/idea/blaze/base/sync/aspects/strategy/SyncAspectTemplateProvider.java
Outdated
Show resolved
Hide resolved
|
Thank you @xuansontrinh |
tpasternak
approved these changes
Nov 25, 2024
github-actions
bot
removed
the
awaiting-review
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this pull request
Nov 25, 2024
…zelbuild#7048) * fix issues with aspect templates not available in query sync mode * revise based on review
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this pull request
Nov 25, 2024
…zelbuild#7048) * fix issues with aspect templates not available in query sync mode * revise based on review
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this pull request
Nov 25, 2024
…zelbuild#7048) * fix issues with aspect templates not available in query sync mode * revise based on review
tpasternak
pushed a commit
to tpasternak/bazel-intellij
that referenced
this pull request
Nov 25, 2024
…zelbuild#7048) * fix issues with aspect templates not available in query sync mode * revise based on review
mai93
added a commit
that referenced
this pull request
Nov 25, 2024
* Fixed Java enabled condition in SyncAspectTemplateProvider (#6987) Removed the check for GENERIC language class when determining if Java is enabled. This change ensures that only the presence of JAVA language class sets the "isJavaEnabled" flag to true. * fix: Properly support non-Java Bazel 8 projects in IntelliJ (#7006) Previously, the condition to load rules_java was based on the "additional languages" field, which led to issues as Java is always present in IntelliJ (unlike PyCharm). This change modifies the condition to explicitly check if rules_java is actually loaded in the project, ensuring proper handling of non-Java projects in IntelliJ. * support aspect template for Python (#7011) * fix issues with aspect templates not available in query sync mode (#7048) * fix issues with aspect templates not available in query sync mode * revise based on review * fix: Don't require rules_java and rules_python for bazel 7 and older (#7052) * doc: Update changelog * Update CHANGELOG --------- Co-authored-by: Daniel Brauner <daniel.brauner@jetbrains.com> Co-authored-by: Jason Trinh <xuanson.trinh@jetbrains.com> Co-authored-by: Mai Hussien <70515749+mai93@users.noreply.github.com>
mai93
added a commit
that referenced
this pull request
Nov 25, 2024
* fix issues with aspect templates not available in query sync mode (#7048) * fix issues with aspect templates not available in query sync mode * revise based on review * fix: Don't require rules_java and rules_python for bazel 7 and older (#7052) * doc: Update changelog * Update CHANGELOG --------- Co-authored-by: Jason Trinh <xuanson.trinh@jetbrains.com> Co-authored-by: Mai Hussien <70515749+mai93@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change: debug on java binary is failing due to not having access to aspect templates
After the change: debug on java binary is successful
