make label parsing more resilient #7257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
ujohnny
reviewed
Jan 27, 2025
base/src/com/google/idea/blaze/base/qsync/QuerySyncProjectData.java
Outdated
Show resolved
Hide resolved
In some cases query sync might return some labels that cannot be validated later on. The actual fix would be to fix query sync to exclude these invalid labels; this just addresses the symptom.
LeFrosch
force-pushed
the
label-validation
branch
from
144b8ef to
d91fb01
Compare
ujohnny
approved these changes
Jan 28, 2025
github-actions
bot
removed
the
awaiting-review
LeFrosch
added a commit
to LeFrosch/intellij-bazel
that referenced
this pull request
Feb 3, 2025
In some cases query sync might return some labels that cannot be validated later on. The actual fix would be to fix query sync to exclude these invalid labels; this just addresses the symptom.
LeFrosch
added a commit
to LeFrosch/intellij-bazel
that referenced
this pull request
Feb 3, 2025
In some cases query sync might return some labels that cannot be validated later on. The actual fix would be to fix query sync to exclude these invalid labels; this just addresses the symptom.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases query sync might return some labels that cannot be validated later on. The actual fix would be to fix query sync to exclude these invalid labels; this just addresses the symptom.