Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix aspect_template reference in java_classpath aspect #7265

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

LeFrosch
Copy link
Collaborator

Discussion thread for this change

Issue number: #7260

Description of this change

One intellij_aspect_template reference was left in java_classpath.bzl causing it to fail at runtime. Also, just to make sure the aspects are present, call AspectStorageService.prepare before using them.

One intellij_aspect_template reference was left in java_classpath.bzl causing it to fail at runtime. Also, just to make sure the aspects are present, call AspectStorageService.prepare before using them.
@LeFrosch LeFrosch changed the title fixed aspect_template reference in java_classpath aspect Fix aspect_template reference in java_classpath aspect Jan 31, 2025
@LeFrosch LeFrosch marked this pull request as ready for review January 31, 2025 15:18
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jan 31, 2025
@mai93 mai93 merged commit 5d1b741 into bazelbuild:master Jan 31, 2025
9 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jan 31, 2025
mai93 pushed a commit that referenced this pull request Jan 31, 2025
One intellij_aspect_template reference was left in java_classpath.bzl causing it to fail at runtime. Also, just to make sure the aspects are present, call AspectStorageService.prepare before using them.

(cherry picked from commit 5d1b741)
LeFrosch added a commit to LeFrosch/intellij-bazel that referenced this pull request Feb 3, 2025
…7265)

One intellij_aspect_template reference was left in java_classpath.bzl causing it to fail at runtime. Also, just to make sure the aspects are present, call AspectStorageService.prepare before using them.
LeFrosch added a commit to LeFrosch/intellij-bazel that referenced this pull request Feb 3, 2025
…7265)

One intellij_aspect_template reference was left in java_classpath.bzl causing it to fail at runtime. Also, just to make sure the aspects are present, call AspectStorageService.prepare before using them.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants