Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[AOSP-pick] Make run configurations configurable #7275

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Feb 4, 2025

Cherry pick AOSP commit 990fdde7dae9cb0964c3e8339c3e8d6698b45e7e.

Let users control the IDE.

  1. Allow breaking links between XML files and run configurations. It
    often happens that one need to modify an imported configuration.
    If syncing is disabled it won't be auto-updated by the sync unless
    the link is re-enabled by the user.

  2. Do not auto-detect the configuration handler every time the set of
    selected build targets change. This may look like being helpful but
    it is not obvious to users. Instead, the IDE should warn users about
    incompatible run configuration handlers.

    This will also prevent the IDE from corrupting run configurations
    imported from XML files.

  3. Keep auto-detecting the handler when the build targets are set for
    the first time since run configuration syncing depends on this
    behavior.

  4. Allow users to choose the run configuration handler manually. It is
    absolutely fine to just build and Android binary target and it is
    also fine to attempt to deploy any other target. Most will fail but
    some may be compatible rules.

  5. In the future, add a button to detect the handler automatically,
    which if needed can query blaze/depserver for the target kind if
    unknown.

NOTE: This does not fix the issues itself and those run configurations
that failed to be imported correctly won't bew imported correctly
afterwards, however this change allows users to fix run
configurations themselves.

Bug: 382099213
Test: n/a (unfortunately)
Change-Id: I979a3cf9f32a0425b2732ee105212aef9985a0ab

AOSP: 990fdde7dae9cb0964c3e8339c3e8d6698b45e7e

Let users control the IDE.

1. Allow breaking links between XML files and run configurations. It
   often happens that one need to modify an imported configuration.
   If syncing is disabled it won't be auto-updated by the sync unless
   the link is re-enabled by the user.

2. Do not auto-detect the configuration handler every time the set of
   selected build targets change. This may look like being helpful but
   it is not obvious to users. Instead, the IDE should warn users about
   incompatible run configuration handlers.

   This will also prevent the IDE from corrupting run configurations
   imported from XML files.

3. Keep auto-detecting the handler when the build targets are set for
   the first time since run configuration syncing depends on this
   behavior.

4. Allow users to choose the run configuration handler manually. It is
   absolutely fine to just `build` and Android binary target and it is
   also fine to attempt to deploy any other target. Most will fail but
   some may be compatible rules.

5. In the future, add a button to detect the handler automatically,
   which if needed can query blaze/depserver for the target kind if
   unknown.

NOTE: This does not fix the issues itself and those run configurations
      that failed to be imported correctly won't bew imported correctly
      afterwards, however this change allows users to fix run
      configurations themselves.

Bug: 382099213
Test: n/a (unfortunately)
Change-Id: I979a3cf9f32a0425b2732ee105212aef9985a0ab

AOSP: 990fdde7dae9cb0964c3e8339c3e8d6698b45e7e
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Feb 4, 2025
@LeFrosch LeFrosch merged commit da8d881 into bazelbuild:master Feb 17, 2025
5 checks passed
@LeFrosch LeFrosch deleted the AOSP/990fdde7dae9cb0964c3e8339c3e8d6698b45e7e branch February 17, 2025 17:24
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Feb 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants