Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Followup: External modules navigation in starlark files #7294

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Feb 10, 2025

followup for #7213

By populating the blazeInfo and externalWorkspaceData fields in
QuerySyncProjectData, similar to how AspectProjectData does, the same
code that handles external module navigation for async also works for
qsync.

@LeFrosch LeFrosch marked this pull request as ready for review February 10, 2025 13:32
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Feb 10, 2025
followup for bazelbuild#7213

By populate the blazeInfo and externalWorkspaceData fields in
QuerySyncProjectData similar to how AspectProjectData does, the same
code that handles external module navigation for async also works for
qsync.
@LeFrosch LeFrosch force-pushed the external-module-navigation branch from 44eca72 to eca625f Compare February 17, 2025 12:45
@LeFrosch
Copy link
Collaborator Author

rebased master

@LeFrosch LeFrosch force-pushed the external-module-navigation branch from eca625f to a251eac Compare February 17, 2025 12:53
@LeFrosch LeFrosch force-pushed the external-module-navigation branch from a251eac to 97869d7 Compare February 17, 2025 13:21
@LeFrosch LeFrosch merged commit c89a5e9 into bazelbuild:master Feb 17, 2025
5 checks passed
@LeFrosch LeFrosch deleted the external-module-navigation branch February 17, 2025 13:45
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Feb 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants