Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

platform.md: Add LoongArch ISA name la64v100 #237

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

cheese
Copy link
Contributor

@cheese cheese commented Jan 8, 2023

This adds the base ISA [1] of the LoongArch architecture to the platform
lexicon.

[1] https://loongson.github.io/LoongArch-Documentation/LoongArch-toolchain-conventions-EN.html
@google-cla
Copy link

google-cla bot commented Jan 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nanonyme
Copy link

RE: legal on arches, isn't a change like this so small that independent of CLA it should not really be problematic?

@EdSchouten
Copy link
Collaborator

Hi @nanonyme,
This is a fair question, whether the CLA should be required for this repository. We brought it up during today's remote execution working group meeting, but unfortunately nobody from Google attended it. I have already placed it on the agenda for next month's meeting. Will keep you posted!

@EricBurnett
Copy link
Collaborator

Apologies for missing the meeting today. I checked the CLA policy documentation internally and I don't see any provision for bypassing it on account of PR size. And logistically, I would not really expect so - a sequence of small changes could become a large change, which the auditing tooling would have to account for, etc...for auditability purposes if nothing else I think Google-run repos (including everything in bazelbuild) do require CLAs on all PRs. Sorry :(.

@EdSchouten
Copy link
Collaborator

I think the question we had in the monthly meeting was whether the CLA should apply to this repo to begin with, considering it merely captures a specification/standard, not an implementation.

@nanonyme
Copy link

nanonyme commented Feb 14, 2023

Note that is now a repeating problem of remote execution ecosystem at large. No one who contributes ISA names (which I don't think are original work, they are just ISA names; if these are original work then they are original work of the creator of the ISA) into the documentation has signed Google CLA resulting in many cases the PR's dragging on for years. While clearly simplest option is @cheese simply signs CLA, this same problem seems to happen every time. Eg it took two years to get someone who had signed Google CLA to submit riscv64 ISA names. #176

@cheese
Copy link
Contributor Author

cheese commented Feb 16, 2023

I have signed Google CLA.

@EricBurnett EricBurnett merged commit ec8e5df into bazelbuild:main Feb 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants