Support digest functions in remote_asset API #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
changed the title
|
cc: @mostynb @EdSchouten |
EdSchouten
approved these changes
Jan 23, 2024
bergsieker
reviewed
Feb 13, 2024
sluongng
force-pushed
the
sluongng/remote_asset_digest_functions
branch
from
0dc9f1b to
ec618ef
Compare
EdSchouten
reviewed
Feb 13, 2024
sluongng
force-pushed
the
sluongng/remote_asset_digest_functions
branch
from
aab12be to
091fb9b
Compare
bergsieker
approved these changes
Apr 9, 2024
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Apr 25, 2024
A follow up from bazelbuild/remote-apis#286 Closes #21996. PiperOrigin-RevId: 628100606 Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 25, 2024
A follow up from bazelbuild/remote-apis#286 Closes bazelbuild#21996. PiperOrigin-RevId: 628100606 Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38
github-merge-queue bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Apr 29, 2024
A follow up from bazelbuild/remote-apis#286 Closes #21996. PiperOrigin-RevId: 628100606 Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38 Commit 618c0ab Commit dcfefd9 (Third party changes) --------- Signed-off-by: iancha1992 <heec@google.com> Co-authored-by: Son Luong Ngoc <sluongng@gmail.com>
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
A follow up from bazelbuild/remote-apis#286 Closes bazelbuild#21996. PiperOrigin-RevId: 628100606 Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow client(like Bazel) to specify the
digest_functionto the remote server (so that--experimental_remote_downloadercould use non-SHA256 digest functions).This is a recreation of #273 with reviewers' comment addressed