Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Issue in README #598

Closed
chrislovecnm opened this issue Dec 4, 2018 · 0 comments · Fixed by #599
Closed

Issue in README #598

chrislovecnm opened this issue Dec 4, 2018 · 0 comments · Fixed by #599

Comments

@chrislovecnm
Copy link 

Alternatively, you can build a docker load compatible bundle with: bazel build my/image:helloworld.tar. This will produce the file: bazel-genfiles/my/image/helloworld.tar, which you can load into your local Docker client by running: docker load -i bazel-genfiles/my/image/helloworld.tar. Building this target can be expensive for large images.

This does not seem to be correct

tars seem to be landing in bazel-bin
@nlopezgi nlopezgi mentioned this issue Dec 4, 2018
Merged
nlopezgi added a commit that referenced this issue Dec 4, 2018
@nlopezgi
update readme (#599)
ebb6ac7 
fix #597
fix #598
provide docs for recommended fix for #317
Improve documentation for xx_image rules to make more explicit that args such as env and symlinks will never be added to xx_image and container_image must be used in conjunction with xx_image for these use cases.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update readme nlopezgi/rules_docker
1 participant
@chrislovecnm