Resolve #1168 by way of a makeshift, in absence of better isolation of the ksp environment. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgruber
requested review from
ahumesky,
restingbull,
Bencodes and
nkoroste
as code owners
…f the ksp environment.
cgruber
force-pushed
the
fix_1168
branch
2 times, most recently
from
e34440b to
f5a2c98
Compare
…Moves to the more recent 3.x version of the protobuf APIs, and uses the non-deprecated print system.
|
Note - this makeshift isn't working, regrettably. It may require a full fix to the isolation. (I'm also talking to the Dagger project about better isolation of their deps via shading - the dagger-compiler should be shaded, so I'm not sure what's up there). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guava is used in a lot of different environments. This causes classloader problems at times, in that parts of guava get loaded early, but other parts are loaded late, in other classloaders, and you end up with conflicts around the boundary.
In #1168 @xinzhengzhang suggested a fix (implemented here) to preload guava, so it is fully loaded and can be resolved without crossing classloader boundaries.
While better classloader isolation is preferable, this at least unblocks folks while a more robust isolation scheme is explored.