Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modernize Bazel setup #20

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Modernize Bazel setup #20

merged 1 commit into from
Oct 15, 2022

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 15, 2022

  • No longer rely on native.bind and the external package
  • Replace host with exec cfg
  • Use ctx.actions.args() instead of string lists
  • Use http_jar instead of jvm_maven_import_external

@fmeum
Modernize Bazel setup
07b225e 
* No longer rely on `native.bind` and the `external` package
* Replace host with exec cfg
* Use `ctx.actions.args()` instead of string lists
* Use `http_jar` instead of `jvm_maven_import_external`
@fmeum fmeum mentioned this pull request Oct 15, 2022
Merged
@fmeum
Copy link
Contributor Author

fmeum commented Oct 15, 2022

This will allow me to add bazel_jar_jar to the Bazel Central Registry.

johnynek
johnynek approved these changes Oct 15, 2022
View reviewed changes
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@johnynek johnynek merged commit e8b1334 into bazeltools:master Oct 15, 2022
@fmeum fmeum deleted the prepare-for-bzlmod branch October 15, 2022 22:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @johnynek