Fix timestamp roundtripping issue #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrobstory
requested changes
Oct 3, 2023
| JarInputStream in = new JarInputStream(new ByteArrayInputStream(baos.toByteArray())); | ||
| je = in.getNextJarEntry(); | ||
| long readTime = StandaloneJarProcessor.fixTimestamp(je.getTime()); | ||
| //assertEquals(readTime, startTime); |
There was a problem hiding this comment.
Probably should remove this comment but: it might be interesting to add assertNotEquals(startTime, je.getTime()) so that this test fails if they fix it in the JDK and we can remove this shim.
There was a problem hiding this comment.
I can't do that because that test will fail on any machine with UTC timezone (which i guess many CI machines would have).
wrobstory
approved these changes
Oct 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.