revert to fix netflix

[johnynek]

two merged PRs to improve caching seem to break us when we run over a larger repo.

I think these PRs are undertested because I am getting:

Exception in thread "main" java.io.IOException: Unable to transform com/<redacted>/<redacted>/CirceCodecs$anon$lazy$macro$217$1$$anon$21.class
        at com.github.johnynek.jarjar.util.JarTransformer.process(JarTransformer.java:41)
        at com.github.johnynek.jarjar.util.JarProcessorChain.process(JarProcessorChain.java:38)
        at com.github.johnynek.jarjar.MainProcessor.process(MainProcessor.java:118)
        at com.github.johnynek.jarjar.util.StandaloneJarProcessor.run(StandaloneJarProcessor.java:57)
        at com.github.johnynek.jarjar.Main.process(Main.java:96)
        at java.lang.reflect.Method.invoke(Method.java:566)
        at com.github.johnynek.jarjar.MainUtil.runMain(MainUtil.java:37)
        at com.github.johnynek.jarjar.Main.main(Main.java:50)
Caused by: java.lang.IllegalArgumentException
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:249)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.parseType(SignatureReader.java:240)
        at org.objectweb.asm.signature.SignatureReader.accept(SignatureReader.java:122)
        at org.objectweb.asm.commons.Remapper.mapSignature(Remapper.java:215)
        at org.objectweb.asm.commons.ClassRemapper.visit(ClassRemapper.java:106)
        at org.objectweb.asm.ClassVisitor.visit(ClassVisitor.java:123)
        at org.objectweb.asm.commons.ClassRemapper.visit(ClassRemapper.java:102)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:569)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:424)
        at com.github.johnynek.jarjar.util.JarTransformer.process(JarTransformer.java:39)
        ... 7 more

so it looks like some method signature is being changed to something that asm can't deal with.

[johnynek]

this reverts #31 and #30 cc @fmeum

I'm happy to reconsider this, but we need to up our testing game.

[fmeum]

@johnynek Thanks for the ping and sorry for the breakage. I can look into this at some point, but I unfortunately lack a very large code base to test this on. If you have some redacted code you could share that triggers this, I could turn it into a test.