Add ConfigJavaInfo to jar jar aspect #51
Conversation
|
|
||
| if ConfigJavaInfo in target: | ||
| java_info_runtime_deps.append(target[ConfigJavaInfo].config_java_info) | ||
| #current_jars.extend([e.class_jar for e in target[ConfigJavaInfo].config_java_info.java_outputs]) |
There was a problem hiding this comment.
we some remove this commented code.
| @@ -6,6 +6,10 @@ ShadedJars = provider(fields = [ | |||
| "transitive_shaded", | |||
| ]) | |||
|
|
|||
| ConfigJavaInfo = provider(fields = [ | |||
There was a problem hiding this comment.
I find this name a bit confusing. I would rather name it something related to runtime_deps. But also, I'm confused why we need this... seems like we shouldn't...
There was a problem hiding this comment.
The problem is that this rule makes the assumption that the target only generates one output JAR, and if it ever has a runtime dependency the target would have an attributed called runtime_deps:
if hasattr(ctx.rule.attr, "runtime_deps"):
for d in ctx.rule.attr.runtime_deps:
if ShadedJars in d:
shaded_jars = d[ShadedJars]
transitive_shaded.append(depset([shaded_jars]))
transitive_shaded.append(shaded_jars.transitive_shaded)
java_info_runtime_deps.append(shaded_jars.java_info)The target we have generates two output one normal JAR and the second JAR for JSON, and as far as we can tell it won't get included into the resulting JavaInfo from this aspect.
|
You said: "We need certain transitive runtime jars to be added to the current jars list." Can you be more explicit? Why do we need certain transitive runtime jars added? Is it because the aspect isn't recursing properly? Maybe that's it because the "certain jars" are coming from a rule that the aspect can't traverse? Maybe we should fix our internal rule... |
Problem:
We need certain transitive runtime jars to be added to the current jars list.
Solution:
This PR creates a provider ConfigJavaInfo that a target can expose with specific jars that need to be added to current jars