Merge branch 'evantypanski:topic/etyp/convert-dd'

bbannier · Nov 4, 2024 · 038acb0 · 038acb0
2 parents a04cced + fd763af
commit 038acb0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/rule-tests/use-dd-test.yml b/rule-tests/use-dd-test.yml
@@ -3,6 +3,7 @@ valid:
   - "type X = unit { x: uint8 { $$; } };"
   - "type X = unit { x: uint8 { other.y; } };"
   - "type X = unit { y: uint8 { self.x; } };"
+  - "type X = unit { x: uint8 &convert=$$ + 5 { self.x; $$; } };"
 invalid:
   - "type X = unit { x: uint8 { self.x; } };"
   - "type X = unit { x: uint8 { if (True) self.x; } };"
diff --git a/rules/use-dd.yml b/rules/use-dd.yml
@@ -25,6 +25,13 @@ rule:
               field: "name"
               kind: "ident"
               pattern: "$F"
+        not:
+          inside:
+            kind: "field_decl"
+            stopBy: "end"
+            has:
+              kind: "attribute"
+              regex: "&convert"
 
 fix: "$$"