Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Run rubocop on each commit on travis #15

Open
stevenjack opened this issue Jul 9, 2015 · 1 comment
Open

Run rubocop on each commit on travis #15

stevenjack opened this issue Jul 9, 2015 · 1 comment
Assignees
@revett
Labels
Enhancement

Comments

@stevenjack
Copy link

Problem

Have to ask people to run rubocop which requires them to set it up and may conflict with rubocop setups they already have. I.e: #11

Solution

Run rubocop on each commit in travis then mark the PR as pass/failure based on the result from rubocop.
@revett
Copy link
Contributor

revett commented Jul 9, 2015

👍

@revett revett self-assigned this Jul 9, 2015
ajohnstone added a commit to ajohnstone/cloudwatch-sender that referenced this issue Jul 10, 2015
@ajohnstone
Resolve - run rubocop on each commit on travis bbc#15
81f58af 
 * Add travis and rubocop
 * Source rubocop config from remote repo
ajohnstone added a commit to ajohnstone/cloudwatch-sender that referenced this issue Jul 10, 2015
@ajohnstone
Resolve - run rubocop on each commit on travis bbc#15
3ca4f21 
 * Add travis and rubocop
 * Source rubocop config from remote repo

@see https://travis-ci.org/ajohnstone/cloudwatch-sender/
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@revett revett

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevenjack @revett