Refactor styling #214
Merged
Refactor styling #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxim Sukharev <max@smacker.ru>
Signed-off-by: Maxim Sukharev <max@smacker.ru>
Signed-off-by: Maxim Sukharev <max@smacker.ru>
We need it to be able to easily override styles. Less instead of any other preprocessor was chosen to match superset one. Similar to styled-components new css classes don't use css cascade and have bblfsh prefix to be unique in a larger application. Components themselves don't import styles to make it easier to integrate to another codebase. Signed-off-by: Maxim Sukharev <max@smacker.ru>
Signed-off-by: Maxim Sukharev <max@smacker.ru>
Signed-off-by: Maxim Sukharev <max@smacker.ru>
carlosms
approved these changes
Apr 30, 2019
this commit doesn't change UI it duplicates resets from normalize.css to the components itself to make it easier to integrate bblfsh-web into other places Signed-off-by: Maxim Sukharev <max@smacker.ru>
se7entyse7en
approved these changes
Apr 30, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need it to be able to easily override styles.
Less instead of any other preprocessor was chosen to match superset one.
Similar to styled-components new css classes don't use css cascade and
have bblfsh prefix to be unique in a larger application.
Components themselves don't import styles to make it easier to integrate
to another codebase.
Standalone UI looks absolutely the same as before. Superset UI with very little overriding:
