Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use LOG_LEVEL env value to set logrus log level #227

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

dpordomingo
Copy link
Member

@dpordomingo dpordomingo commented Oct 24, 2019

fix #221

LOG_LEVEL can be any of debug, info, warning, error
If bblfsh backend is run with --debug flag, log level will be trace


This change is Reviewable

server/cmd/bblfsh-web/main.go Show resolved Hide resolved
server/cmd/bblfsh-web/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. but I agree with Marvin that debug & tracing looks confusing.

@dpordomingo
Copy link
Member Author

Push forced: b7cc318

  • docs for LOG_LEVEL env value,
  • --debug and LOG_LEVEL is now independent, and it's up to the user to set both or not.

LOG_LEVEL can be any of debug, info, warning, error
If bblfsh backend is ran with --debug flag, log level will be 'trace'

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo merged commit 01521fa into bblfsh:master Oct 28, 2019
@dpordomingo dpordomingo deleted the logs branch October 28, 2019 11:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read the logging level from an environment var
3 participants