Don't use deprecated Rack::VERSION in Rack 3 #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @etiennebarrie . I appreciate the fix and enabling deprecation warning by default in webmock specs. |
|
Thanks for releasing a new version this quickly! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I upgraded Rack, I got a few deprecation warnings regarding the usage of
Rack::VERSIONinlib/webmock/rack_response.rb.This conditionally adds the key to the Rack environment, since not only it's no longer required but it's also deprecated.
I also added a commit to enable deprecation warnings by default, it's not something that RSpec does but it can be useful like in this case. Let me know (or just remove that commit) if you'd rather not have that.