Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

For a more consistent API, completely replace Email API with the Builder. Add support for InternetAddress. #114

Closed
bbottema opened this issue Nov 5, 2017 · 2 comments
Closed

For a more consistent API, completely replace Email API with the Builder. Add support for InternetAddress. #114

bbottema opened this issue Nov 5, 2017 · 2 comments
Assignees
@bbottema
Labels
enhancement major feature Priority-Low
Milestone
5.0.0

Comments

@bbottema
Copy link
Owner

bbottema commented Nov 5, 2017

Email's API and the EmailBuilder API are more or less the same, resulting in a lot of duplicate state / synchronization code, while not adding much in terms of usability.

To keep de code base concise and the API consistent and simple, make Email completely immutable as a build result from the EmailBuilder.
@bbottema bbottema added this to the 5.0.0 milestone Nov 5, 2017
@bbottema bbottema self-assigned this Nov 17, 2017
bbottema added a commit that referenced this issue Nov 26, 2017
@bbottema
#114: First version of the complete recipients redesign
507b0f2
bbottema added a commit that referenced this issue Nov 26, 2017
@bbottema
#114: Added JavaDoc for the recipient methods
79b74d0
@bbottema bbottema changed the title For a more consistent API, completely replace Email API with the Builder For a more consistent API, completely replace Email API with the Builder. Add support for InternetAddress. Nov 26, 2017
bbottema added a commit that referenced this issue Nov 26, 2017
@bbottema
#114: Added InternetAddress support for bounceTo, withDispositionNoti…
d9fe746 
…ficationTo and withReturnReceiptTo
bbottema added a commit that referenced this issue Nov 26, 2017
@bbottema
#114: Added InternetAddress support for from() and replyTyo()
4cbc8bb
bbottema added a commit that referenced this issue Dec 3, 2017
@bbottema
#114: Split up the initializing builder methods from populating build…
9c673ab 
…er methods. Starters are: replyingTo, replyingToAll, forwarding, startingBlank and copying (not yet implemented)
bbottema added a commit that referenced this issue Dec 5, 2017
@bbottema
#114: - Added reset methods to clear fields in builder
0e0b8a9 
      - Resolved all static analyses issues (reported by IntelliJ)
      - Made Email immutable and all the fields final (excpet ID, which is updated during sending email)
@bbottema
Copy link
Owner Author

bbottema commented Dec 5, 2017

Merged EmailBuilder-rewrite into master.

@bbottema bbottema closed this as completed Dec 5, 2017
bbottema added a commit that referenced this issue Dec 6, 2017
@bbottema
#114: Taking into account optionality for some fields
c279bd6
bbottema added a commit that referenced this issue Dec 24, 2017
@bbottema
#114: added API to add String based recipients with custom recipient …
e879484 
…type
@bbottema
Copy link
Owner Author

Released as 5.0.0.rc1-SNAPSHOT. Add OSS' snapshots repo to find it in Maven.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bbottema bbottema

Labels
enhancement major feature Priority-Low
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@bbottema