Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: include <string> in binary_buffer.h for fix macos builds #852

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

chenrui333
Copy link
Contributor

include <string> to fix some compile issue as below

  In file included from /tmp/diamond-20250125-4855-7vw53/diamond-2.1.11/src/basic/packed_transcript.h:21:
  /tmp/diamond-20250125-4855-7vw53/diamond-2.1.11/src/util/binary_buffer.h:93:8: error: implicit instantiation of undefined template 'std::basic_string<char>'
                                  dst.push_back(c);
                                     ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/iosfwd:248:32: note: template is declared here
      class _LIBCPP_TEMPLATE_VIS basic_string;
                                 ^

relates to Homebrew/homebrew-core#205487

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title fix: include <string> instead of <string.h> in binary_buffer.h fix: include <string> in binary_buffer.h for fix macos builds Jan 25, 2025
@bbuchfink bbuchfink merged commit 6cd35e3 into bbuchfink:master Jan 26, 2025
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants