Reference System.Memory and use it in math/raw #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
commented
Oct 6, 2024
| @@ -6,6 +6,7 @@ | |||
| <AssemblyOriginatorKeyFile>..\..\BouncyCastle.NET.snk</AssemblyOriginatorKeyFile> | |||
| <SignAssembly>true</SignAssembly> | |||
| <NoWarn>1591</NoWarn> | |||
| <LangVersion>10.0</LangVersion> | |||
There was a problem hiding this comment.
Only needed for Index/Range syntax
Rob-Hague
commented
Oct 6, 2024
Comment on lines
+95
to
+97
| <ItemGroup Condition=" '$(TargetFramework)' == 'net461' "> | ||
| <PackageReference Include="System.ValueTuple" Version="4.5.0" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Only needed for Index/Range syntax
Rob-Hague
commented
Oct 6, 2024
Comment on lines
+112
to
+115
| <PackageReference Include="PolySharp" Version="1.14.1"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> |
There was a problem hiding this comment.
Only needed for Index/Range syntax
|
I like updates which have more BALEETED than add. The code we don't have is code we don't need to maintain 💯 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This change represents an initial/example contribution towards #550. It adds a reference to System.Memory and uses it to deduplicate a number of internal code paths.
The change is kept isolated to one directory (src/math/raw) for sympathy with review. If this change is accepted, there is more that can be done in other layers of the library.
This also adds a reference to System.ValueTuple on net461 and a private reference to PolySharp. These are not necessary but allow using Index/Range syntax on lower targets.
How has this been tested?
Existing unit tests
Checklist before requesting a review
See also Contributing Guidelines.