Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make node_version a required field #20

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Conversation

craigyu
Copy link
Contributor

@craigyu craigyu commented Jun 12, 2023

remove default node_version and make it a required field

@craigyu craigyu added the enhancement New feature or request label Jun 12, 2023
@craigyu craigyu self-assigned this Jun 12, 2023
@craigyu craigyu linked an issue Jun 12, 2023 that may be closed by this pull request
@DerekRoberts DerekRoberts force-pushed the 19-make-node_required branch 2 times, most recently from 0202ec8 to f6a23d7 Compare August 11, 2023 21:45
@DerekRoberts DerekRoberts self-requested a review August 11, 2023 21:45
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea and approved! :) ...BTW I added to the README.

@DerekRoberts DerekRoberts force-pushed the 19-make-node_required branch from dd3145d to 0ea0250 Compare August 11, 2023 22:09
@DerekRoberts DerekRoberts force-pushed the 19-make-node_required branch from 674f385 to f8a7c1a Compare August 12, 2023 17:33
@DerekRoberts DerekRoberts force-pushed the 19-make-node_required branch from f8a7c1a to a6debdd Compare August 12, 2023 17:34
@DerekRoberts DerekRoberts merged commit 3865175 into main Aug 12, 2023
@DerekRoberts DerekRoberts deleted the 19-make-node_required branch August 12, 2023 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make node_version a required field
2 participants