Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

19754 Update amalgamation resources for Certify component #653

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Feb 12, 2024

Issue #: bcgov/entity#19754

Description of changes:

  • app version = 5.8.13
  • removed redundant first certify bullet
  • set certify entity display to "business"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

- removed redundant first certify bullet
- set entity display to "business"
@severinbeauvais severinbeauvais self-assigned this Feb 12, 2024
ResourcePhrases.AMALGAMATION_CANNOT_BE_REVERSED
],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old:

image

New:

image

@severinbeauvais
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-create-dev--pr-653-2qjaz79j.web.app

Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@severinbeauvais severinbeauvais merged commit 572113f into bcgov:main Feb 12, 2024
5 checks passed
JazzarKarim pushed a commit to JazzarKarim/business-create-ui that referenced this pull request Feb 23, 2024
- removed redundant first certify bullet
- set entity display to "business"

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants