Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

22845 - Update Confirm Page Delivery Email #729

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

ArwenQin
Copy link
Collaborator

@ArwenQin ArwenQin commented Sep 3, 2024

Issue #: /bcgov/entity#22845

Description of changes:

  • For the review & confirm page, updated the Documents Delivery Section:
    Made the Completing Party email address editable
    Keep prepopulating the default staff email address
  • Only when it's a staff filing
  • Updated for Amalgamation, Dissolution, Continuation, Incorporation, Registration.
  • Restoration seems not needed/ not updated.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Sep 3, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-create-dev--pr-729-0xdxe2m1.web.app

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Sep 3, 2024

Dissolution before update:
image

Keep the same design, update the default staff email address:
image

For Amalgamation, Dissolution, Continuation, Incorporation, and Registration, use the same design as the above:
image

When it's not a staff filing, keep previous design, not changed:
image

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Sep 3, 2024

Restoration seems not needed/ not updated:
image
The 2 emails are from step 2 and step 3

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please report what kind of testing you did (which filings, and both as staff and regular user). Thanks.

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Sep 4, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-create-dev--pr-729-0xdxe2m1.web.app

@ArwenQin ArwenQin merged commit 0388fcd into bcgov:main Sep 4, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants