23833 Small text/style changes #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed share structure button styles (outlined) - added punctuation to some hint text - bolded and fixed layout of share structure instruction text (x3) - changed incorporation -> continuation in document delivery section - updated unit tests
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-750-mrecsz68.web.app |
ScreenshotsAdd Person buttons
Add Share Class buttons
Continuation Application "must include" text
Incorporation Application "must include" text
Amalgamation Application (regular) "must include text
|
severinbeauvais
commented
Oct 16, 2024
| @@ -79,8 +79,10 @@ | |||
| </section> | |||
| </v-expand-transition> | |||
|
|
|||
| <p>Your application must include the following:</p> | |||
There was a problem hiding this comment.
The paragraph element always has extra whitespace. Instead of overriding it, I use a div, same as in other places.
severinbeauvais
commented
Oct 16, 2024
ketaki-deodhar
approved these changes
Oct 16, 2024
ArwenQin
approved these changes
Oct 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#23833
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).