Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update cd.yml #765

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Update cd.yml #765

merged 1 commit into from
Feb 6, 2025

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Feb 5, 2025

Issue #: None

Description of changes:

  • removed triggers that automatically deploy feature and hotfix branches to Dev

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

- removed triggers to automatically deploy feature and hotfix branches to Dev
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Feb 5, 2025

Reviewers, what are you thoughts on this change?

This came about because a feature branch was automatically deployed to Dev when PRs were merged to it. We only realized this when a feature stopped working in Dev.

image

With this change, we would have to explicitly deploy a feature branch to Dev. I think that's much safer!

@cameron-eyds
Copy link
Collaborator

cameron-eyds commented Feb 5, 2025

Reviewers, what are you thoughts on this change?

This came about because a feature branch was automatically deployed to Dev when PRs were merged to it. We only realized this when a feature stopped working in Dev.

image

With this change, we would have to explicitly deploy a feature branch to Dev. I think that's much safer!

@severinbeauvais
I agree with you, that a feature/hotfix branch deployment should be explicit.
Will help avoid this scenario when the committer is unaware that feature-xx will trigger a deployment, even if it is convenient when everyone is aware.

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with this change. LGTM.

@severinbeauvais severinbeauvais merged commit 8a3d3bf into main Feb 6, 2025
10 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants