Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

25803 - Update Business-Search Version (New CS Type) #766

Merged

Conversation

ArwenQin
Copy link
Collaborator

@ArwenQin ArwenQin commented Feb 6, 2025

Issue #: /bcgov/entity#25803

Description of changes:

  • Update Business-Search Version to use the new CS Type in search list

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin ArwenQin self-assigned this Feb 6, 2025
@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Feb 6, 2025

I checked the version updated in Business Search Component, Create UI is up to the most recent update:
image
image

@@ -21,7 +21,7 @@
"@bcrs-shared-components/approval-type": "1.1.3",
"@bcrs-shared-components/base-address": "2.0.3",
"@bcrs-shared-components/breadcrumb": "2.1.15",
"@bcrs-shared-components/business-lookup": "1.3.4",
"@bcrs-shared-components/business-lookup": "1.3.15",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intermediate versions are probably just dependency updates (like enums). Thanks for checking!

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you tested this and it's working fine.

@ArwenQin ArwenQin merged commit ac8fd93 into bcgov:main Feb 6, 2025
8 of 10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants