Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create UI: implement new Amalgamating Businesses component - Part I - DO THIS FIRST! #18535

Closed
5 of 6 tasks
severinbeauvais opened this issue Nov 10, 2023 · 7 comments
Closed
5 of 6 tasks
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 10, 2023

This ticket is the first third of this new component.

To do:

New added items to complete by Karim:

  • Implement save and resume
  • Add businesses to an initially-empty table

UXPin: https://preview.uxpin.com/7f4cfe5fe4b0ba15a83d518177efe82a08e99167#/pages/164774938/simulate/sitemap

Notes:

  • Pure EP Amalgamations are out of scope
  • Assume all searched businesses are in LEAR (not in COLIN only)
  • EP (A type) and other Foreign businesses cannot be part of a Short Form Horizontal amalgamation.
@severinbeauvais severinbeauvais added the ENTITY Business Team label Nov 10, 2023
@severinbeauvais severinbeauvais changed the title Create UI: implement framework Create UI: implement new Amalgamating Businesses component Nov 11, 2023
@Mihai-QuickSilverDev Mihai-QuickSilverDev changed the title Create UI: implement new Amalgamating Businesses component Create UI: implement new Amalgamating Businesses component - Part I Nov 17, 2023
@Mihai-QuickSilverDev Mihai-QuickSilverDev changed the title Create UI: implement new Amalgamating Businesses component - Part I Create UI: implement new Amalgamating Businesses component - Part I - DO THIS FIRST! Nov 17, 2023
@severinbeauvais
Copy link
Collaborator Author

The updated design for "3 text fields to add a foreign business" now includes a nested dropdown for the home jurisdiction, which complicates things a bit. See how this is done in Namerequuest UI and port that code over. I think this still fits in the estimate of 5.

cc: @yuisotozaki

@Mihai-QuickSilverDev
Copy link
Collaborator

I have added an extra comment on the Notes, please let me know if you have any questions.

@severinbeauvais
Copy link
Collaborator Author

EP (A type) and other Foreign businesses cannot be part of a Short Form Horizontal amalgamation.

Not even for staff? OK, the table ticket (18640) that I am working on will have to implement that validation.

@severinbeauvais
Copy link
Collaborator Author

@JazzarKarim Looks like you're doing this, right?

image

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Dec 4, 2023

@JazzarKarim Looks like you're doing this, right?

image

Yes Sev! I'm still missing two features that I'm going to work on though:

  1. Fetching the emails
  2. Only fetch BCs, CCs, ULCs, BENs, and As.

@JazzarKarim
Copy link
Collaborator

UXA / Test Notes:

You can use this URL: https://dev.create.business.bcregistry.gov.bc.ca/amalg-reg-information?id=ToP7r12FpT&accountid=3040
Or an amalgamation from the MBR.

@yuisotozaki
Copy link

Ready for QA

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants