Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create UI: implement new Amalgamating Businesses component - Part II #18722

Closed
2 of 3 tasks
severinbeauvais opened this issue Nov 23, 2023 · 5 comments
Closed
2 of 3 tasks
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 23, 2023

  • create new sub-component for adding a foreign business
    • see UI designs
    • no MRAS search
    • reuse nested select from Namerequest
    • reuse Canada provinces (incl Federal) from Namerequest
    • reuse International countries from Namerequest
    • possibly show United States + list of states no
  • consider what the data looks like, for inclusion into the table
    • no email
    • no address
  • unit tests moved to Create UI: implement new Amalgamating Businesses component - Part IV - DO THIS LAST #18641
@yuisotozaki
Copy link

yuisotozaki commented Dec 15, 2023

Observations:

  • The required field error message needs to be updated as follows:
    • Home jurisdiction is required
    • Full legal name is required
    • Corporate number is required

image.png

@leodube-aot
Copy link
Collaborator

@yuisotozaki I just merged a PR with these changes

@yuisotozaki
Copy link

The error messages look good.

I noticed that we don't have a limit to the business name and corporate number field. We want to mimic what Name Request does for extra provincial registration.
image.png

  • Corporate name field should have a 150 character limit; same as Name
  • Corporate number field should have a 40 character limit and disallow no space
  • Corporate number field should be optional if the home jurisdiction is not part of the MRAS list

@leodube-aot
Copy link
Collaborator

@yuisotozaki Updated with the new validation rules!

@yuisotozaki
Copy link

Ready for QA.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants