Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Name Examination Vue 3: Auto-add button not working/Conflict options selected automatically. #20999

Closed
oanyahuru opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working Names Team Name Request Name Examination Team Priority1

Comments

@oanyahuru
Copy link
Collaborator

Examiners used to be able to toggle between “auto adding” potential conflicts on the old version using the button.
image.png

On Vue3 seems to automatically select potential conflicts which the examiner must manually click to remove each one, which is time consuming. The auto-add button appears to be grayed out on the Vue 3 page. Auto checks were more efficient when users had the ability to uncheck the auto add button and make their selections as needed.
image.png

@Mihai-QuickSilverDev
Copy link
Collaborator

@shaangill025 Hi Shaanjot, should the fix be in Test? I do not see it.
@ozamani9gh

@shaangill025
Copy link
Collaborator

shaangill025 commented Jun 25, 2024

@Mihai-QuickSilverDev It is in Test, I just checked it again.

@shaangill025
Copy link
Collaborator

@ozamani9gh I have a follow up PR that prevents the examiner from changing the auto selected conflict lists. Currently, with auto add checked on the examiner can select/de-select conflicts and those changes will persists. So, if examiner makes change with auto add check on, checks off auto add and then decides to just go with auto selected conflicts by checking auto add back on then the conflict lists will be the modified one and not the original one.

bcgov/name-examination#1480, this PR makes it so that changes made to auto selected conflicts with auto add checked on do not persist.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working Names Team Name Request Name Examination Team Priority1
Projects
None yet
Development

No branches or pull requests

4 participants