20999 - Auto Add Fix: Make Initial Conflicts List Immutable #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
shaangill025
requested review from
eve-git,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1480-kgcsvz7s.web.app |
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1480-kgcsvz7s.web.app |
|
Looks good. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#20999
Description of changes:
With Initial PR, users were able to modify the automatically selected conflict lists with
auto addchecked on and this would persists. With these changes, the automatically selected conflict lists would remain immutable but users can uncheckauto addand then make their selections.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).