Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Examination screen keyboard navigation #1440

Merged
merged 40 commits into from
Mar 26, 2024

Conversation

semmatti
Copy link
Contributor

@semmatti semmatti commented Mar 26, 2024

Issue #:
bcgov/entity#20335
bcgov/entity#20336

Description of changes:
This PR implements keyboard navigation for the Examine screen. Changes include:

  • Pressing tab now cycles between recipe search inputs and the conflicts area when the conflicts tab is selected.
  • Keyboard navigation implemented for the conflicts area.
    • up arrow/down arrow: focus the next/previous conflict
    • right arrow: expand the focused conflict
    • left arrow: collapse the focused conflict
    • space: select the focused conflict

Additionally, components in the conflicts tab were refactored.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@semmatti
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1440-62j7a94i.web.app

@semmatti semmatti force-pushed the keyboard_navigation_refactor branch from 5d638ec to 3f862cd Compare March 26, 2024 20:01
@semmatti
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1440-62j7a94i.web.app

@semmatti
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1440-62j7a94i.web.app

@semmatti semmatti force-pushed the keyboard_navigation_refactor branch from c192fff to 838a8c1 Compare March 26, 2024 21:36
@semmatti
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1440-62j7a94i.web.app

@semmatti semmatti merged commit 8d639bc into bcgov:main Mar 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants