Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

20343 Fix alt + E shortcut opening browser settings #1442

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

semmatti
Copy link
Contributor

@semmatti semmatti commented Apr 2, 2024

Issue #:
bcgov/entity#20343

Description of changes:
This PR prevents the default browser actions from firing when a mnemonic shortcut is pressed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@semmatti
Copy link
Contributor Author

semmatti commented Apr 2, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1442-jkgqrrxj.web.app

@eve-git
Copy link
Collaborator

eve-git commented Apr 3, 2024

The version number needs to be updated to 1.2.11

@eve-git eve-git self-requested a review April 3, 2024 17:21
@semmatti semmatti force-pushed the fix_alt_e_shortcut branch from 82c06ee to 60298f4 Compare April 3, 2024 20:31
@semmatti
Copy link
Contributor Author

semmatti commented Apr 3, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1442-jkgqrrxj.web.app

@semmatti semmatti merged commit 35b00c9 into bcgov:main Apr 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants