Bugfix/20344 history tab irrelevant past rejection #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:flutistar/name-examination into bugfix/20344-history-tab-irrelevant-past-rejection
flutistar
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag and
EPortman
as code owners
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1483-abb7b7hb.web.app |
|
I also did the same thing Roland did, I started off rejecting 'FRIDAY FUNDAY EVENTS LTD' - 0531273 And then I went to examine 'FRIDAY FUNDAY EVENTS LTD' - 0809933. It did not display anything in the history tab. On a side note, is this the behavior we want for the history tab? It seems like these are not relevant (20+ duplicates). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: 20344
Description of changes:
Removed special characters from query string for History tab.
Before cleaning.
After cleaning
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).