23752 use runtime config when fetching namex version #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPortman
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag and
flutistar
as code owners
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1551-1g5ueeaa.web.app |
ozamani9gh
approved these changes
Jan 8, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/23752
Description of changes:
Nuxt3 does not expose environment variables directly for security reasons which was causing this method to fail and default to the dev configuration.
This PR makes use of the runtime config to get these environment variables instead that are defined here:
https://github.com/bcgov/name-examination/blob/main/app/nuxt.config.ts#L43
Also this PR gets rid of the default values so when it does not work it is obvious and does not potentially give the 'wrong version'.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).