18510 - Add extra step to set transactions to REFUNDED if billable = 'f' #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
seeker25
commented
Nov 8, 2023
| @@ -76,6 +77,8 @@ def process_cfs_refund(self, invoice: InvoiceModel) -> str: # pylint:disable=un | |||
| 2.1 Return REFUND_REQUESTED | |||
| """ | |||
| current_app.logger.info(f'Received JV refund for invoice {invoice.id}, {invoice.invoice_status_code}') | |||
| if not payment_account.billable: | |||
There was a problem hiding this comment.
The only non-billable account we have is for EJV - for SBC_STAFF
Codecov Report
@@ Coverage Diff @@
## main #1321 +/- ##
==========================================
+ Coverage 91.45% 93.76% +2.30%
==========================================
Files 186 136 -50
Lines 11319 8702 -2617
==========================================
- Hits 10352 8159 -2193
+ Misses 967 543 -424
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ochiu
approved these changes
Nov 8, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#18510
Description of changes:
Should fix: bcgov/entity#17772
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).