Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: migrates CI from Circle CI to Github actions #1144

Merged
merged 2 commits into from
May 31, 2023
Merged

ci: migrates CI from Circle CI to Github actions #1144

merged 2 commits into from
May 31, 2023

Conversation

theanmolsharma
Copy link
Collaborator

@theanmolsharma theanmolsharma commented Mar 5, 2023 •
edited
Loading

This PR migrates CI from Circle CI to Github actions.

Proof of Work 😜 : theanmolsharma#2

@masterchief164
Copy link
Collaborator

Could you please also give an example of the coverallsapp action. The rest of the actions seems great!

@masterchief164
Copy link
Collaborator

Also do create separate issues for the Todos

@pinheadmz
Copy link
Member

Yeah I think this looks good, those TODOs can be future PRs. @theanmolsharma is this ready to merge?

@theanmolsharma
Copy link
Collaborator Author

Yeah I think this looks good, those TODOs can be future PRs. @theanmolsharma is this ready to merge?

Not yet ready to merge. Need to investigate options for commenting test coverage report. Preferably something that edits old comments instead of creating a new one everytime the tests run.

@masterchief164
Copy link
Collaborator

Yeah I think this looks good, those TODOs can be future PRs. @theanmolsharma is this ready to merge?

Not yet ready to merge. Need to investigate options for commenting test coverage report. Preferably something that edits old comments instead of creating a new one everytime the tests run.

Maybe the old coverage bot codecov might be helpful. Just found a way to integrate it with github actions
This might be helpful.

@theanmolsharma theanmolsharma force-pushed the gh-actions branch 3 times, most recently from 8f5788f to 34bdc10 Compare May 11, 2023 18:37
@theanmolsharma theanmolsharma force-pushed the gh-actions branch 2 times, most recently from 9393178 to 3ecc500 Compare May 29, 2023 18:21
@theanmolsharma
Copy link
Collaborator Author

@pinheadmz
This PR is ready to be merged.

@theanmolsharma theanmolsharma requested a review from pinheadmz May 29, 2023 18:30
@theanmolsharma theanmolsharma deleted the gh-actions branch May 30, 2023 04:07
@theanmolsharma theanmolsharma restored the gh-actions branch May 30, 2023 04:08
@pinheadmz pinheadmz merged commit 2221495 into bcoin-org:master May 31, 2023
@theanmolsharma theanmolsharma deleted the gh-actions branch May 31, 2023 14:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pinheadmz pinheadmz Awaiting requested review from pinheadmz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theanmolsharma @masterchief164 @pinheadmz