Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Does it support pnpm? #117

Closed
ozum opened this issue Jul 12, 2023 · 4 comments
Closed

Does it support pnpm? #117

ozum opened this issue Jul 12, 2023 · 4 comments

Comments

@ozum
Copy link

ozum commented Jul 12, 2023

Hi,

I looked run-task.js and saw yarn is supported. Is there a pnpm support?

Kind regards,

@bcomnes
Copy link
Owner

bcomnes commented Jul 12, 2023

Looks like there is no direct accommodation of pnpm, however there is a good chance it still works since npm-run-all2 takes over mostly once tasks are invoked with it.

Give it a shot and let me know if you run into any issues.

@kinland
Copy link
Contributor

kinland commented Sep 29, 2023

Doesn't seem to work for me, unfortunately. Likely the same issue as #108, which you mentioned might be related to 61e84ea

╭─      ~/repos/kinland/eslint-config-kinland  on    wip wip +5 !5 ················· ✔  at 09:01:39 PM   ─╮
╰─ run-s clean build                                                                                                 ─╯
node:internal/errors:490
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:399:5)
    at validateString (node:internal/validators:163:11)
    at Object.basename (node:path:1309:5)
    at /home/kinland/repos/kinland/eslint-config-kinland/node_modules/.pnpm/npm-run-all2@6.0.6/node_modules/npm-run-all2/lib/run-task.js:159:47 {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v18.16.1

╭─      ~/repos/kinland/eslint-config-kinland  on    wip wip +5 !5 ··············· 1 ✘  at 09:01:55 PM   ─╮
╰─ pnpm run clean                                                                                                    ─╯

> eslint-config-kinland@1.0.0 clean /home/kinland/repos/kinland/eslint-config-kinland
> rm -rf dist ; find . -name tsconfig.tsbuildinfo -delete ; rm -f .eslintcache


╭─      ~/repos/kinland/eslint-config-kinland  on    wip wip +5 !5 ················· ✔  at 09:02:02 PM   ─╮
╰─ pnpm run build                                                                                                    ─╯

> eslint-config-kinland@1.0.0 build /home/kinland/repos/kinland/eslint-config-kinland
> tsc && mv ./dist/.eslintrc.js ./dist/.eslintrc.cjs

I am working on a PR.

kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
@kinland
Copy link
Contributor

kinland commented Sep 29, 2023

PR up. If anyone sees this before the PR eventually gets merged, you can temporarily use my fork. kinland/npm-run-all2@feature/117-pnpm-support

kinland pushed a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
kinland added a commit to kinland/npm-run-all2 that referenced this issue Sep 29, 2023
bcomnes pushed a commit that referenced this issue Oct 4, 2023
bcomnes pushed a commit that referenced this issue Oct 4, 2023
@bcomnes
Copy link
Owner

bcomnes commented Oct 4, 2023

Should work now, thanks @kinland

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants