Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: move to read-package-json-fast #130

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: move to read-package-json-fast #130

merged 1 commit into from
Jan 31, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jan 30, 2024

This moves away from read-pkg to a much, much lighter package maintained by the npm team themselves (read-package-json-fast).

Saves us ~90k of install size and the time spent fetching the 15-20 dependencies read-pkg has

This moves away from read-pkg to a much, much lighter package maintained
by the npm team themselves (read-package-json-fast).
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/read-package-json-fast@3.0.2 filesystem +2 22.1 kB lukekarrys

🚮 Removed packages: npm/read-pkg@8.1.0

View full report↗︎

@bcomnes
Copy link
Owner

bcomnes commented Jan 31, 2024

Right on, let's see if it breaks anything in CI.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (79e2c97) 96.82% compared to head (62b8703) 96.31%.
Report is 16 commits behind head on master.

Files Patch % Lines
lib/run-task.js 84.81% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   96.82%   96.31%   -0.52%     
==========================================
  Files          35       35              
  Lines        2080     2114      +34     
==========================================
+ Hits         2014     2036      +22     
- Misses         66       78      +12     
Flag Coverage Δ
macos-latest-18 96.22% <85.00%> (-0.53%) ⬇️
ubuntu-latest-18 95.83% <85.00%> (-0.53%) ⬇️
windows-latest-18 95.85% <85.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcomnes
Copy link
Owner

bcomnes commented Jan 31, 2024

Looks good, will test locally and release tomorrow.

@43081j
Copy link
Contributor Author

43081j commented Jan 31, 2024

Thanks so much for taking a look so soon! 🙏

@bcomnes
Copy link
Owner

bcomnes commented Jan 31, 2024

No problem. I'll take all the easy, future facing improvements this can get!

@bcomnes bcomnes merged commit fdb3b79 into bcomnes:master Jan 31, 2024
11 of 13 checks passed
@43081j 43081j deleted the rpjf branch January 31, 2024 23:03
@bcomnes
Copy link
Owner

bcomnes commented Jan 31, 2024

Give https://github.com/bcomnes/npm-run-all2/releases/tag/v6.1.2 a shot.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants