Merge pull request #1115 from tleedjarv/o_append-win

Add a comment about O_APPEND in `openfile` for Windows
bcpierce00 · Jan 23, 2025 · 707ae12 · 707ae12
2 parents e857a2d + 9b11426
commit 707ae12
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/system/system_win.ml b/src/system/system_win.ml
@@ -79,6 +79,11 @@ let rename f1 f2 =
 
 let chown _ _ _ = raise (Unix.Unix_error (Unix.ENOSYS, "chown", ""))
 
+(* TODO: O_APPEND in [Unix.openfile] for Windows was fixed in OCaml 5.3.
+   Remove the entire [openfile] definition below once the minimum supported
+   compiler version is >= 5.3.
+   Note: at the time of adding this comment, there is actually no code calling
+   [openfile] with O_APPEND. *)
 let openfile f flags perm =
   let fd = Unix.openfile f flags perm in
   (* Comment from original C stub implementation: