Skip to content

Add BSplineSE3 class. #128

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Add BSplineSE3 class. #128

merged 11 commits into from
Jul 9, 2024

Conversation

myeatman-bdai
Copy link
Collaborator

@myeatman-bdai myeatman-bdai commented Jul 9, 2024

This adds a class to represent SE3 trajectories using a b-spline (using scipy's b-spline class under the hood). A small example is included, with a visualization.

Fixes a minor bug with the animation functionality.

Copy link
Collaborator

@jcao-bdai jcao-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. would it help to add some tests?

@myeatman-bdai myeatman-bdai requested a review from jcao-bdai July 9, 2024 18:13
@myeatman-bdai
Copy link
Collaborator Author

I'm going to merge and come back and fix these failing tests later.

@myeatman-bdai myeatman-bdai merged commit 6074eb7 into master Jul 9, 2024
2 of 19 checks passed
@myeatman-bdai myeatman-bdai deleted the b-spline-SE3 branch July 9, 2024 18:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants